core/vm: fix PC increment for EIP-8024 opcodes#33361
Merged
Merged
Conversation
Contributor
|
Good catch. I merged the original PR without really giving it a deep look, since we will have lots of testcases later. |
fjl
approved these changes
Dec 8, 2025
weiihann
pushed a commit
to weiihann/go-ethereum
that referenced
this pull request
Jan 14, 2026
The EIP says to increment PC by 2 _instead of_ the standard increment by 1. The opcode handlers added in ethereum#33095 result in incrementing PC by 3, because they ignored the increment already present in `interpreter.go`. Does this need to be better specified in the EIP? I've added a [new test case](ethereum/EIPs#10859) for it anyway. Found by @0xriptide.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Apr 2, 2026
25 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Apr 13, 2026
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EIP says to increment PC by 2 instead of the standard increment by 1. The opcode handlers added in #33095 result in incrementing PC by 3, because they ignored the increment already present in
interpreter.go.Does this need to be better specified in the EIP? I've added a new test case for it anyway.
Found by @0xriptide.